Mutually exclusive buttons & open window

edm11 · February 6, 2021, 5:18am

Like this?

Var
   group1_sound1 : PluginBlock
   group1_btn1 : Widget

On WidgetValueChanged (btval : double) from group1_btn1
    if ModifierKeys() == 2 and btval > 0.5
        then OpenPlugin(group1_sound1)
        Else ClosePlugin(group1_sound1)
    end
    If btval >0.5
        then SetPluginBypassed(group1_sound1, false)
        else SetPluginBypassed(group1_sound1, true)
    end
End

You have to put in the other declarations and statements before you End the sequence from On WidgetValueChanged.

brandon · February 6, 2021, 3:00pm

@edm

That likely does work and I can test it in a different gig… but in my gig, that crashed GP completely and I suspect this is why:

I have another part of my script with the following variables:

Var
TimerStarted : Boolean
StartTime : double
Delay : double

Now this is just a guess… because this is quickly getting over my head, but I think the true, false syntax is creating a feedback loop of somekind and hanging GP.

I myself tried almost what you sent using ‘false’ last night and it crashed GP.

Here’s the rest of that script I am referring to:

> 
> //leslie break script//
> 
> initialization
>  TimerStarted = false
>  Delay = 410
>  SetTimersRunning(true)
> end 
>    
> on Activate
>  TimerStarted = false
>  SetTimersRunning(true)
> end 
> 
> On WidgetValueChanged(newValue : double) from speed1
> 
>  if ParamToMidi(newValue) >= 20
>     and ParamToMidi(newValue) <= 110 then
>   if TimerStarted == false then
>     SetTimersRunning(true)
>     TimerStarted = true
>     StartTime = TimeSinceStartup()
>   end  
>  
>  else
>   brake1.SetWidgetValue(0.0)
>   brake2.SetWidgetValue(0.0)
>   brake3.SetWidgetValue(0.0)
>   SetTimersRunning(false)
>   TimerStarted = false
>  end 
>     
> End
> 
> on TimerTick(ms : double)
>  if TimeSinceStartup() >= StartTime + Delay then
>   brake1.SetWidgetValue(1.0)
>   brake2.SetWidgetValue(1.0)
>   brake3.SetWidgetValue(1.0)
>  end 
> end

I am putting ALL of my Var for all my script sections at the very top of my script to keep that in one place, I don’t know if where those are expressed matters or not.

While I’d ultimately like to know if I am correct in my assumption that true/false is the culprit of the crashing… I also wonder if it’s possible to get around this by using an integer or double instead but when I try that I get an error of incompatible value.

brandon · February 6, 2021, 3:40pm

I can confirm that if I remove my //leslie break script// from my overall script, then adding the SetPluginBypassed action doesn’t crash GP so while I don’t understand why this is, my hunch is correct… it’s a conflict with the boolean true/false that creates a ‘death spiral’.

@dhj I know were in un-supported territory here but just a FYI… when this crash occurs it doesn’t dump out to the GP crash notification screen… I just get the GP has stopped working and will be reported to Windows screen.

dhj · February 6, 2021, 4:22pm

Is it a crash or is it a hang? These are different!

brandon · February 6, 2021, 4:26pm

in the parlance of Windows 10… paraphrasing here…

“The application GP has encountered a problem and stopped working and this will be reported to Bill Gates”

the application will eventually disappear on it’s own, I don’t have to force quit… so I’d call that a crash.

jpt · February 6, 2021, 4:42pm

I get this often too…out of the blue.

dhj · February 6, 2021, 4:46pm

“Stopped working” generally just means that Windows didn’t detect any GUI activity after a certain amount of time passed. That’s generally due to a hang and eventually Windows will kill it. So if you are in GPScript and have setup an infinite loop such that nothing else can happen then that is essentially a hang, not a crash

brandon · February 6, 2021, 6:22pm

So I think I have solved the issue that caused the hang just by reordering my scripts.

If I put the SetPluginBypassed script before my //leslie break script// both scripts function normally and clicking the bypass button doesn’t hang GP.

But if I reverse the order of these scripts, clicking the bypass button does hang GP.

dhj · February 6, 2021, 6:30pm

I don’t understand – there is only one script (per rackspace, say) — how are you reordering it?

brandon · February 6, 2021, 6:37pm

Here’s the order that works without the hang:

//bypass button open plugin script//

then…

//leslie break script//

> Var
>    TimerStarted : Boolean
>    StartTime : double
>    Delay : double
> 
>    brake1, brake2, brake3 : Widget
>    speed1, speed2, speed3 : Widget
>     
> 	group1_btn1 : widget
> 	group1_sound1 : PluginBlock
> 
> //bypass button open plugin script//
>     
> On WidgetValueChanged (btval : double) from group1_btn1
> if ModifierKeys() == 2 and btval > 0.5
>         then OpenPlugin(group1_sound1)
>         Else ClosePlugin(group1_sound1)
>     end
>     If btval >0.5
>         then SetPluginBypassed(group1_sound1, false)
>         else SetPluginBypassed(group1_sound1, true)
>     end
> End
> 
> 
> //leslie break script//
> 
> initialization
>  TimerStarted = false
>  Delay = 410
>  SetTimersRunning(true)
> end 
>    
> on Activate
>  TimerStarted = false
>  SetTimersRunning(true)
> end 
> 
> On WidgetValueChanged(newValue : double) from speed1
> 
>  if ParamToMidi(newValue) >= 20
>     and ParamToMidi(newValue) <= 110 then
>   if TimerStarted == false then
>     SetTimersRunning(true)
>     TimerStarted = true
>     StartTime = TimeSinceStartup()
>   end  
>  
>  else
>   brake1.SetWidgetValue(0.0)
>   brake2.SetWidgetValue(0.0)
>   brake3.SetWidgetValue(0.0)
>   SetTimersRunning(false)
>   TimerStarted = false
>  end 
>     
> End
> 
> on TimerTick(ms : double)
>  if TimeSinceStartup() >= StartTime + Delay then
>   brake1.SetWidgetValue(1.0)
>   brake2.SetWidgetValue(1.0)
>   brake3.SetWidgetValue(1.0)
>  end 
> end	

If I reverse the order like follows, when I click on group1_btn1, then I get the hang.

> Var
>    TimerStarted : Boolean
>    StartTime : double
>    Delay : double
> 
>    brake1, brake2, brake3 : Widget
>    speed1, speed2, speed3 : Widget
>     
> 	group1_btn1 : widget
> 	group1_sound1 : PluginBlock
> 
> //leslie break script//
> 
> initialization
>  TimerStarted = false
>  Delay = 410
>  SetTimersRunning(true)
> end 
>    
> on Activate
>  TimerStarted = false
>  SetTimersRunning(true)
> end 
> 
> On WidgetValueChanged(newValue : double) from speed1
> 
>  if ParamToMidi(newValue) >= 20
>     and ParamToMidi(newValue) <= 110 then
>   if TimerStarted == false then
>     SetTimersRunning(true)
>     TimerStarted = true
>     StartTime = TimeSinceStartup()
>   end  
>  
>  else
>   brake1.SetWidgetValue(0.0)
>   brake2.SetWidgetValue(0.0)
>   brake3.SetWidgetValue(0.0)
>   SetTimersRunning(false)
>   TimerStarted = false
>  end 
>     
> End
> 
> on TimerTick(ms : double)
>  if TimeSinceStartup() >= StartTime + Delay then
>   brake1.SetWidgetValue(1.0)
>   brake2.SetWidgetValue(1.0)
>   brake3.SetWidgetValue(1.0)
>  end 
> end	
> 
> //bypass button open plugin script//
>     
> On WidgetValueChanged (btval : double) from group1_btn1
> if ModifierKeys() == 2 and btval > 0.5
>         then OpenPlugin(group1_sound1)
>         Else ClosePlugin(group1_sound1)
>     end
>     If btval >0.5
>         then SetPluginBypassed(group1_sound1, false)
>         else SetPluginBypassed(group1_sound1, true)
>     end
> End

Both script //sections// work independently no issue… but adding another instance of using the Boolean true, false in the same script, depending on the order it is used, creates the hang.

I’d love to understand why.

(this is a paired down version of my full script)

dhj · February 6, 2021, 10:07pm

I don’t have time to do user script debugging (and frankly it doesn’t hepp that your script is not properly indented to at least make it readable) but would note that your OnTimerTick should actually stop the timer once it reaches the correct time otherwise it’s going to just keep setting those widget values on every tick.

This is a single script – not two separate scripts. The order of callbacks should not matter one bit.

brandon · February 6, 2021, 10:26pm

sorry about the indentation… it happens when I paste in for some reason, it’s not like that in the script.

yes, i get that it’s one script… but the order of the callbacks is definitely what determines if the crash is triggered or not. I’ve tested that numerous times and it’s the variable.

I’ll try to figure out the Timer, thanks for the suggestion.

I’m attaching the exported script in case anyone wants to take a look. The way this is exported is the way in which it does not crash.

DEFAULT Script.zip (1.3 KB)

dhj · February 6, 2021, 10:28pm

dhj · February 6, 2021, 10:30pm

If that’s true, there’s something very deeply wrong with GPScript — really needs a short script to demonstrate this.

brandon · February 6, 2021, 10:37pm

I’m sure this is not the case… must be another variable. I’ll try to pressure test some more on this issue.

celoranta · June 9, 2021, 4:10am

Bump for radio button widgets.
I’ve got a group of seven mutually exclusive buttons I want to automate. I will dig in with GPScript but also register my interest here.

timhongbo · April 17, 2024, 2:52pm

I tried to follow the file you provided, and when switching between variations, the button just blinks and recovers, not visually switching or mutual exclusion, i.e.: the led indicator is lit but does not stay on, and doesn’t work as a constant reminder of the current state (e.g. out of a certain page).

Is it possible to modify the script code to help me realize a toggle variation like the one in your file?

Thank you!

schamass · April 17, 2024, 3:42pm

No need for scripting anymore, there is an in-built function for radio buttons since V4.7 (I guess).
Just put the buttons into the same radio group (must not be 0) and you are good to go!
Search the manual for “radio group”… it should be well documented.

timhongbo · April 17, 2024, 5:26pm

I’ll keep trying!

Thank you!